Remove UnsafeBeyond2Pow53Minus1 type suffixes
#3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42214f5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 25, 2024
lorisleiva
force-pushed
the
loris/remove-usafe-type-suffixes
branch
from
7647088 to
b02834e
Compare
lorisleiva
requested review from
steveluscher,
mcintyre94 and
buffalojoec
and removed request for
steveluscher
lorisleiva
changed the base branch from
loris/use-bigint-json-serialization-in-rpc-subscriptions
to
graphite-base/3456
lorisleiva
force-pushed
the
loris/remove-usafe-type-suffixes
branch
from
b02834e to
42214f5
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both RPC and RPC Subscriptions packages now use custom JSON serialization to safely convert large integers as
bigintsfrom the server requests/responses. This means we are no longer handlingbigintsthat are unsafe below2^53-1which also means we can remove theUnsafeBeyond2Pow53Minus1suffixes to all types currently using it.Note that the
F64UnsafeSeeDocumentationtype is excluded from this refactoring as the bigint serialization only affects integers.