Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolve U64 and I64 RPC types #3467

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Oct 27, 2024

This PR removes the U64 and I64 types by replacing their instances with bigint, as requested in this thread.

Copy link

changeset-bot bot commented Oct 27, 2024

🦋 Changeset detected

Latest commit: 57d36a4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite Graphite

@lorisleiva lorisleiva marked this pull request as ready for review October 27, 2024 18:12
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types are no longer a lie.

Added via Giphy

@lorisleiva lorisleiva merged commit 3834d82 into master Oct 28, 2024
9 checks passed
@lorisleiva lorisleiva deleted the loris/dissolve-u64-i64-types branch October 28, 2024 10:45
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants