This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Skip gossip requests with different shred version #10240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
changed the title
sakridge
force-pushed
the
shred-version-filter
branch
from
5d20c3c to
b80e768
Compare
Codecov Report
@@ Coverage Diff @@
## master #10240 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 288 288
Lines 66608 66704 +96
=========================================
+ Hits 54303 54371 +68
- Misses 12305 12333 +28 |
sakridge
force-pushed
the
shred-version-filter
branch
from
b80e768 to
5f1e9de
Compare
sakridge
commented
May 26, 2020
sakridge
force-pushed
the
shred-version-filter
branch
from
5f1e9de to
30f23ee
Compare
carllin
reviewed
May 26, 2020
| if shred_version != 0 && shred_version != my_shred_version { | ||
| // Allow someone to update their own ContactInfo if they | ||
| // can change shred versions if needed. | ||
| crds_values.retain(|crds_value| match &crds_value.data { |
There was a problem hiding this comment.
clippy might yell at you to make this an if let since it's only matching one case.
sakridge
force-pushed
the
shred-version-filter
branch
from
30f23ee to
31092d5
Compare
carllin
previously approved these changes
May 26, 2020
|
I wonder if the filter read lock taking a long time will start affecting validators pushing things like |
sakridge
force-pushed
the
shred-version-filter
branch
from
31092d5 to
01445b4
Compare
Yea, it's definitely not ideal. That one and also other heavy read users like |
sakridge
force-pushed
the
shred-version-filter
branch
from
01445b4 to
c51051d
Compare
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2020
) (cherry picked from commit 3f508b3)
solana-grimes
pushed a commit
that referenced
this pull request
May 28, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
) (cherry picked from commit 3f508b3)
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Jun 8, 2020
…ana-labs#10240) (cherry picked from commit 3f508b3)
sakridge
added a commit
that referenced
this pull request
Jun 9, 2020
* Skip gossip requests with different shred version and split lock (#10240) (cherry picked from commit 3f508b3) * More cluster stats and add epoch stakes cache in retransmit stage (#10345) * More cluster info metrics for push request/response counts * Cache staked peers for the epoch (cherry picked from commit ef37b82) * Cache tvu peers for broadcast (#10373) (cherry picked from commit 2cf719a) * Add pull request count metrics (#10421) (cherry picked from commit 3d2230f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cross-network gossip traffic creating extra work for validators.
Write lock contention on
process_pull_requestscauses other users on the gossip lock to go slow.Summary of Changes
Only process requests from peers where shred_version == 0 or shred_version matches our own.
Split process_pull_requests into process_pull_requests and generate_pull_responses. Only proccess_pull_requests needs to take the write lock.
Fixes #