This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Cache tvu peers for broadcast #10373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
broadcast-opt
branch
2 times, most recently
from
74195dd to
5427afc
Compare
carllin
reviewed
Jun 2, 2020
carllin
previously approved these changes
Jun 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #10373 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 288 288
Lines 67094 67172 +78
=========================================
+ Hits 54590 54650 +60
- Misses 12504 12522 +18 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2020
(cherry picked from commit 2cf719a)
solana-grimes
pushed a commit
that referenced
this pull request
Jun 3, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Jun 8, 2020
(cherry picked from commit 2cf719a)
sakridge
added a commit
that referenced
this pull request
Jun 9, 2020
* Skip gossip requests with different shred version and split lock (#10240) (cherry picked from commit 3f508b3) * More cluster stats and add epoch stakes cache in retransmit stage (#10345) * More cluster info metrics for push request/response counts * Cache staked peers for the epoch (cherry picked from commit ef37b82) * Cache tvu peers for broadcast (#10373) (cherry picked from commit 2cf719a) * Add pull request count metrics (#10421) (cherry picked from commit 3d2230f)
ryoqun
reviewed
Jul 22, 2021
Comment on lines
+314
to
+317
| && self | ||
| .last_peer_update | ||
| .compare_and_swap(now, last, Ordering::Relaxed) | ||
| == last |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Broadcast get_peers taking 100s of ms on testnet which delays the broadcast and also creates more contention on the gossip lock so other things like votes cannot happen sooner.
Summary of Changes
Keep broadcast peers cached and update from 1 thread every second.
Fixes #