This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor execute_instruction() for extraction from bank #1772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We talk about the "runtime" in the contracts engine RFC, but it's not in a module or a struct of its own. It's some set of Bank methods acting on a subset of Bank state. Without that separation, it'll be difficult to ask others to scrutinize that mission-critical code.
Proposed changes:
Refactoring such that
execute_instruction()
could be extracted from the bank. Next step is to moveexecute_instruction()
into a new runtime.rs. Stopped here so that the PR diff is manageable.cc: #1528