Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Not clear which part of the bank is the runtime #1528

Closed
garious opened this issue Oct 17, 2018 · 1 comment
Closed

Not clear which part of the bank is the runtime #1528

garious opened this issue Oct 17, 2018 · 1 comment
Assignees

Comments

@garious
Copy link
Contributor

garious commented Oct 17, 2018

Problem:

We talk about the "runtime" in the contracts engine RFC, but it's not in a module or a struct of its own. It's some set of Bank methods acting on a subset of Bank state. Without that separation, it'll be difficult to ask others to scrutinize that mission-critical code.

Proposed solution:

Split the bank. execute_and_commit_transactions() everything it calls to a new runtime.rs module.

Depends on #1529

@garious garious added this to the v0.11 Tabletops milestone Oct 17, 2018
@garious garious changed the title Not clear which part of the bank is LAMPORT Not clear which part of the bank is the runtime Nov 6, 2018
@garious garious self-assigned this Nov 6, 2018
@garious
Copy link
Contributor Author

garious commented Nov 12, 2018

execute_and_commit_transactions(), as previously proposed, might be too much for runtime.rs. Instead, only execute_transaction() looks useful on its own. A client could use it to test their transactions and then assume ACID when submitting those same transactions to a Solana cluster.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant