Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Extract execute_transaction() from the bank #1925

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Nov 27, 2018

Problem

Even if runtime.rs was moved into the SDK, a developer still couldn't write unit tests for their transactions.

Summary of Changes

  • Move execute_transaction() from bank to runtime
  • Fix with_subset() to allow mutable references to be passed to its closure. cc: @aeyakovenko
  • No longer load the same loader accounts multiple times for one transaction
  • Rename ProgramError::RuntimeError to ProgramError::GenericError
  • Add RuntimeError to runtime.rs

Fixes #1528

@garious garious requested review from mvines and rob-solana November 27, 2018 06:38
This might cause a TPS boost in batched BPF transactions, since
now it'll only clone its account once per transaction instead of
once per instruction.
This makes execute_transactions() stateless.
Copy link
Contributor

@rob-solana rob-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@garious garious merged commit a7562c9 into solana-labs:master Nov 27, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
…js (solana-labs#1925)

Bumps [rollup](https://github.com/rollup/rollup) from 2.50.6 to 2.52.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.50.6...v2.52.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yihau pushed a commit to yihau/solana that referenced this pull request Jul 18, 2024
…abs#1895) (solana-labs#1925)

Deprecate RpcClient::get_stake_activation (solana-labs#1895)

* Deprecate RpcClient::get_stake_activation

* Fixup redelegation test

(cherry picked from commit 114041c)

Co-authored-by: Tyera <tyera@anza.xyz>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants