feat(connection.ts): implement getTransactions #23633
Conversation
implement getTransactions which retrieves multiple transaction responses in a single RPC call
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
| }); | ||
|
|
||
| const unsafeRes = await this._rpcBatchRequest(batch); | ||
| const res = unsafeRes.map((unsafeRes: any) => { |
There was a problem hiding this comment.
Somehow, the type of res here is any, despite TypeScript knowing the type of res.result.
Fixed in #26099.
There was a problem hiding this comment.
I wonder if this is because both variables are named the same, and one shadows the other.
There was a problem hiding this comment.
If true, we should definitely install the no-shadow linter. https://eslint.org/docs/rules/no-shadow
There was a problem hiding this comment.
I figured out why this happened. We had insufficient type coverage here, so you missed this error. #26102
implement getTransactions which retrieves multiple transaction responses in a single RPC call Co-authored-by: obiwan <you@example.com>
implement getTransactions which retrieves multiple transaction responses in a single RPC call Co-authored-by: obiwan <you@example.com>
implement getTransactions which retrieves multiple transaction responses in a single RPC call Co-authored-by: obiwan <you@example.com>
implement getTransactions which retrieves multiple transaction responses in a single RPC call Co-authored-by: obiwan <you@example.com>
implement getTransactions which retrieves multiple transaction responses in a single RPC call Co-authored-by: obiwan <you@example.com>
implement getTransactions which retrieves multiple transaction responses in a single RPC call
Problem
currently
getParsedConfirmedTransactionsis the only method which lets you retrieve multiple txs in a single call, however theParsedTransactionWithMetastructure is different from aTransactionResponsestructureSummary of Changes
implement getTransactions which retrieves multiple transaction responses in a single RPC call
Fixes #