This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
chore: correct the types of Rpc{Batch}Request
to prevent type errors in Connection.ts
#26102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The return value of these was incorrect, leading to an
any
propagating through the code, which led to real breakages in the framework (eg. #26099).Summary of Changes
When we properly represent this return type as a promise for an array then array methods like
map()
return correct types.