Add cloned to bank in block_subscribe #24799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
approved these changes
Apr 28, 2022
CriesofCarrots
approved these changes
Apr 28, 2022
|
I'm going to go through the bank forks api to remove all methods which return a borrowed value. It's really bad to hold a read lock on bank forks |
|
praise be to @jstarry |
|
Closed by #24805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On my M1 Max, was running into some type of bank_forks deadlock issue. I'm not able to reproduce it yet on my Linux machine, but changing to this makes the issue go away.
Summary of Changes
Add .cloned() to bank and drop lock immediately after grabbing Arc