Do not hold lock unnecessarily when hashing #24815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
approved these changes
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #24815 +/- ##
=========================================
+ Coverage 81.8% 82.0% +0.1%
=========================================
Files 632 598 -34
Lines 167499 165559 -1940
Branches 322 0 -322
=========================================
- Hits 137169 135857 -1312
+ Misses 30217 29702 -515
+ Partials 113 0 -113 |
t-nelson
approved these changes
Apr 29, 2022
|
I'd like to have all the locking fixes backported, any objections? |
t-nelson
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
(cherry picked from commit a73f998)
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
(cherry picked from commit a73f998)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
Bank::hash_internal_state(), the call to rehash unnecessarily holds theHardForkslock longer than necessary.Note that the
hash::extend_and_hash()function is likely very fast, but we were also holding the lock while performing I/O via theinfo!()call, which is relatively an eternity.This investigation was prompted by @buffalu in Discord and their comment here: #24799 (comment)
Summary of Changes
Get the hash data outside of the
if letso as to not hold the lock unnecessarily.