Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetransmitStage now gets a BankForks #2872

Closed
wants to merge 1 commit into from
Closed

Conversation

mvines
Copy link
Member

@mvines mvines commented Feb 21, 2019

BankForks for everbody!

@mvines mvines added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Feb 21, 2019
@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Feb 21, 2019
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to merge conflict

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Feb 21, 2019
@mvines
Copy link
Member Author

mvines commented Feb 21, 2019

😠

@mvines
Copy link
Member Author

mvines commented Feb 21, 2019

Landed manually: 7cb695d

@mvines mvines closed this Feb 21, 2019
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2872 into master will decrease coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2872     +/-   ##
========================================
- Coverage    78.2%   78.2%   -0.1%     
========================================
  Files         127     127             
  Lines       19403   19405      +2     
========================================
  Hits        15175   15175             
- Misses       4228    4230      +2

@mvines mvines deleted the bf branch February 21, 2019 21:00
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Oct 22, 2024
* extract account-decoder-client-types and convert UiAccount::encode to a free func encode_ui_account

* rip out more types and replace some usage in rpc-client and rpc-client-api

* rip out more types

* remove remaining account-decoder usage from rpc-client

* remove account-decoder from rpc-client-api and transaction-status-client-types

* make zstd optional

* fix import

* ignore some lint

* update some conversions

* missing import

* missing import

* unused imports

* fmt

* don't feature-gate any variants of UiAccountEncoding

* fmt

* update newer code that used UiAccount::encode

* remove sdk dep from account-decoder-client-types

* add doc_auto_cfg like in solana-labs#3121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants