Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot token and storage modules from the SDK #3121

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

garious
Copy link
Contributor

@garious garious commented Mar 5, 2019

Problem

The SDK should only have modules needed to develop programs.

Summary of Changes

Move token_program.rs and storage_program.rs into new *_api crates.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #3121 into master will decrease coverage by 1.5%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #3121     +/-   ##
========================================
- Coverage    78.7%   77.1%   -1.6%     
========================================
  Files         134     134             
  Lines       20086   20487    +401     
========================================
- Hits        15809   15806      -3     
- Misses       4277    4681    +404

1 similar comment
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #3121 into master will decrease coverage by 1.5%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #3121     +/-   ##
========================================
- Coverage    78.7%   77.1%   -1.6%     
========================================
  Files         134     134             
  Lines       20086   20487    +401     
========================================
- Hits        15809   15806      -3     
- Misses       4277    4681    +404

@garious garious merged commit 885eeec into solana-labs:master Mar 5, 2019
alessandrod pushed a commit to alessandrod/solana that referenced this pull request Oct 13, 2024
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Oct 22, 2024
* extract account-decoder-client-types and convert UiAccount::encode to a free func encode_ui_account

* rip out more types and replace some usage in rpc-client and rpc-client-api

* rip out more types

* remove remaining account-decoder usage from rpc-client

* remove account-decoder from rpc-client-api and transaction-status-client-types

* make zstd optional

* fix import

* ignore some lint

* update some conversions

* missing import

* missing import

* unused imports

* fmt

* don't feature-gate any variants of UiAccountEncoding

* fmt

* update newer code that used UiAccount::encode

* remove sdk dep from account-decoder-client-types

* add doc_auto_cfg like in solana-labs#3121
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Oct 22, 2024
* extract transaction-error crate

* update TransactionError usage in sdk

* fix frozen-abi support

* make serde optional in solana-transaction-error

* update lock file

* fmt

* add #[cfg(not(target_os = "solana"))] where applicable

* fmt

* put solana-transaction-error behind feature "full"

* use workspace lints

* update digest

* make rustc_version optional

* avoid frozen-abi build script

* add back workspace lints

* remove thiserror

* remove unused build deps

* use solana-instruction directly

* move AddressLoaderError and SanitizeMessageError to transaction-error, and fix its solana-instruction dep features

* lint

* move TransportError to transaction-error crate

* use doc_auto_cfg like in solana-labs#3121

* missing comma

* add deprecations to re-exports
yihau pushed a commit to yihau/solana that referenced this pull request Oct 28, 2024
* extract packet crate

* typo

* sort deps

* update digest

* add doc_auto_cfg like in solana-labs#3121

* fix frozen-abi
joncinque added a commit to joncinque/solana that referenced this pull request Nov 6, 2024
* extract signer crate

* fmt

* fix bs58 std usage

* extract seed-derivable crate

* extract seed-phrase crate

* fix copy-pasted doc

* extract presigner crate

* make keypair module optional in solana-signer

* remove serde_json dep and fix test features

* remove thiserror from solana-signer

* lint

* more lint

* fix dev dep feature

* sort deps

* remove itertools from solana-signer

* move wasm impl to signer crate

* add doc_auto_cfg like in solana-labs#3121

* post-rebase fix

* another post-rebase fix

* fmt

* make keypair functionality of solana-seed-phrase optional

* fix feature-gated imports

* Extract solana-keypair, move other things around

* Cleanup things that I missed

* Remove space

* Add deprecated notice

* Add deprecation notices

* Refactor SeedDerivable trait implementation

---------

Co-authored-by: Jon C <me@jonc.dev>
Lichtso pushed a commit to Lichtso/solana that referenced this pull request Nov 7, 2024
* extract signer crate

* fmt

* fix bs58 std usage

* extract seed-derivable crate

* extract seed-phrase crate

* fix copy-pasted doc

* extract presigner crate

* make keypair module optional in solana-signer

* remove serde_json dep and fix test features

* remove thiserror from solana-signer

* lint

* more lint

* fix dev dep feature

* sort deps

* remove itertools from solana-signer

* move wasm impl to signer crate

* add doc_auto_cfg like in solana-labs#3121

* post-rebase fix

* another post-rebase fix

* fmt

* make keypair functionality of solana-seed-phrase optional

* fix feature-gated imports

* Extract solana-keypair, move other things around

* Cleanup things that I missed

* Remove space

* Add deprecated notice

* Add deprecation notices

* Refactor SeedDerivable trait implementation

---------

Co-authored-by: Jon C <me@jonc.dev>
joncinque pushed a commit to joncinque/solana that referenced this pull request Nov 7, 2024
* minimize solana_sdk use in reserved_account_keys

* extract reserved-account-keys crate

* fix frozen-abi support in reserved-account-keys

* move id definitions to sdk-ids

* also move the IDs of zk_token_proof_program and zk_elgamal_proof_program

* fix some paths

* missing dev dep

* add doc_auto_cfg like in solana-labs#3121

* fix copied sysvar id

* fix missing dep after rebase

* move stake::program::declare_id to stake::declare_id

* post-rebase fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant