This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
remove dead code #3141
Merged
remove dead code #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Mar 5, 2019
rob-solana
added
the
automerge
sagar-solana
approved these changes
Mar 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #3141 +/- ##
========================================
- Coverage 78.8% 78.7% -0.1%
========================================
Files 134 134
Lines 20045 19969 -76
========================================
- Hits 15797 15728 -69
+ Misses 4248 4241 -7 |
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Nov 7, 2024
* minimize solana_sdk use in reserved_account_keys * extract reserved-account-keys crate * fix frozen-abi support in reserved-account-keys * move id definitions to sdk-ids * also move the IDs of zk_token_proof_program and zk_elgamal_proof_program * fix some paths * missing dev dep * add doc_auto_cfg like in solana-labs#3121 * fix copied sysvar id * fix missing dep after rebase * move stake::program::declare_id to stake::declare_id * post-rebase fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A fair amount of leader scheduling code was written to work around not having
epoch stakes cached in the bank. This code is incompatible with warmup epochs.
Summary of Changes
Remove unused, incompatible code