Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banking worker #30970

Merged
merged 22 commits into from
May 25, 2023
Merged

Banking worker #30970

merged 22 commits into from
May 25, 2023

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Mar 29, 2023 •
edited
Loading

Problem

Worker threads to be sent work by scheduler.

Summary of Changes

Blocked by #30925, #30976

Fixes #

@apfitzge apfitzge added the work in progress This isn't quite right yet label Mar 29, 2023
@apfitzge apfitzge force-pushed the feature/banking_worker branch 2 times, most recently from f324eef to 62eef22 Compare March 29, 2023 22:47
@codecov
Copy link

codecov bot commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #30970 (22213a0) into master (3ac5bb2) will increase coverage by 0.0%.
The diff coverage is 91.6%.

@@           Coverage Diff            @@
##           master   #30970    +/-   ##
========================================
  Coverage    81.9%    81.9%            
========================================
  Files         737      739     +2     
  Lines      205981   206391   +410     
========================================
+ Hits       168738   169156   +418     
+ Misses      37243    37235     -8

@apfitzge apfitzge added noCI Suppress CI on this Pull Request CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request labels Apr 28, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label May 1, 2023
@apfitzge apfitzge marked this pull request as ready for review May 3, 2023 21:45
@apfitzge apfitzge requested review from ryoqun and tao-stones May 3, 2023 21:45
@apfitzge apfitzge removed the work in progress This isn't quite right yet label May 4, 2023
@apfitzge
Copy link
Contributor Author

rebased on a conflict 😦

@apfitzge apfitzge requested a review from ryoqun May 23, 2023 23:27
ryoqun
ryoqun approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitless lgtm. thanks so much as before for addressing all my review comments sincerely.

@apfitzge apfitzge merged commit 75954dc into solana-labs:master May 25, 2023
@apfitzge apfitzge deleted the feature/banking_worker branch May 25, 2023 17:16
@apfitzge apfitzge mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryoqun ryoqun ryoqun approved these changes

@tao-stones tao-stones Awaiting requested review from tao-stones

Assignees
No one assigned
Labels
None yet
Projects
Transaction Scheduler Stage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apfitzge @ryoqun @solana-grimes