Fix merge issues: Arc::clone and ConnectionCache construction #31825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
reviewed
May 30, 2023
| @@ -157,7 +158,7 @@ mod tests { | |||
| poh_recorder, | |||
| bank_forks, | |||
| cluster_info, | |||
| Arc::default(), | |||
| Arc::new(ConnectionCache::new("test")), | |||
There was a problem hiding this comment.
This should have been connection_cache_test as in other cases in #31803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#30970 broke builds due to changes from #31803 and #31717
Summary of Changes
Arc::clonebank for set_bank in consumer testsConnectionCacheno longer has a default implementation, construct it.Fixes #