set_bank takes owned Arc<Bank> #31717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31717 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 737 737
Lines 205985 205985
=========================================
- Hits 168719 168697 -22
- Misses 37266 37288 +22 |
ryoqun
reviewed
May 23, 2023
| @@ -1948,7 +1948,7 @@ impl ReplayStage { | |||
| poh_recorder | |||
| .write() | |||
| .unwrap() | |||
| .set_bank(&tpu_bank, track_transaction_indexes); | |||
| .set_bank(tpu_bank, track_transaction_indexes); | |||
There was a problem hiding this comment.
yay, one less clone for block generation code path. :)
ryoqun
reviewed
May 23, 2023
| assert!(self.working_bank.is_none()); | ||
| self.leader_bank_notifier.set_in_progress(bank); | ||
| self.leader_bank_notifier.set_in_progress(&bank); |
There was a problem hiding this comment.
hehe, set_in_progress seems to be a rare exception for this Arc<_> arg fixup saga... lol
There was a problem hiding this comment.
Yeah, I think the exception is justified as it does not take ownership of the Arc. It uses the arc to create a weak-reference.
(I know you know this, just making it clear for anyone else looking at the PR why this should be an exception)
ryoqun
reviewed
May 23, 2023
Comment on lines
+582
to
+583
| bank, | ||
| start: Arc::new(Instant::now()), |
There was a problem hiding this comment.
oh, unfortunate reordering due to unhappy borrow checker. ;)
ryoqun
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
set_bankis taking ownership of theArc<Bank>.Summary of Changes
Update function signature.
Fixes #