Replace executor cache usage with LoadedPrograms cache #31462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
10 times, most recently
from
1c14a1d to
a637d9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #31462 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 734 734
Lines 205241 205290 +49
=========================================
+ Hits 166922 166934 +12
- Misses 38319 38356 +37 |
dmakarov
previously approved these changes
May 5, 2023
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
from
610e995 to
5c02c6d
Compare
Lichtso
reviewed
May 8, 2023
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
from
5c02c6d to
07b470b
Compare
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
2 times, most recently
from
ddfe184 to
33bbaf5
Compare
Lichtso
reviewed
May 8, 2023
| @@ -58,7 +58,8 @@ impl MessageProcessor { | |||
| transaction_context: &mut TransactionContext, | |||
| rent: Rent, | |||
| log_collector: Option<Rc<RefCell<LogCollector>>>, | |||
| tx_executor_cache: Rc<RefCell<TransactionExecutorCache>>, | |||
| programs_loaded_for_tx_batch: Rc<RefCell<LoadedProgramsForTxBatch>>, | |||
There was a problem hiding this comment.
These three might not even require Rc<RefCell<>>, but that can be refactored later.
Lichtso
previously approved these changes
May 8, 2023
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
from
33bbaf5 to
fa55d49
Compare
pgarg66
force-pushed
the
use-loaded-programs-cache
branch
from
fa55d49 to
3c7d2ed
Compare
Lichtso
approved these changes
May 9, 2023
|
Hey @pgarg66! The bpf loader tests (and probably the implementation) in web3.js broke with this change. Want to help fix them? I'm here if you need help. solana-labs/solana-web3.js#1308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need updates to the code to replace executor cache with LoadedPrograms cache.
Summary of Changes
Updated bank, loader and associated files to replace executor cache with loaded programs cache.
Fixes #