This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Use current root slot to disambiguate pruning of old programs #31548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ForkGraph
returnsBlockRelation::Unknown
for programs deployed before current root slot. That causes pruning of such programs from the cache.Summary of Changes
The
bank_forks
retains slot relationship history till the current root. The pruning has the following logic.BankForks::set_root()
gets called when a new root slot is identified.set_root()
calls cache'sprune()
method before actually storing the new root slot (i.e. cache's view of ForkGraph still has the old root slot).prune()
callsForkGraph::relationship()
trait method on the BankForks object with new root, and program's deployment slot.This logic doesn't work if the deployment slot is older than the current root. Ideally it should be an ancestor of the new root. But the BankForks doesn't have enough history to calculate this relationship, and returns
Unknown
.prune()
callsForkGraph::relationship()
trait method on the BankForks object with new root, and program's deployment slot.or, the deployment slot is older than the previous root,
it's retained in the cache (and first ancestor found flag is set).
Fixes #