This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rename CustomError to Custom #9207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't worry me, it's source backwards incompatible but no affect to binaries AFAICT |
|
@mvines, Thoughts on also modifying |
|
wfm |
Codecov Report
@@ Coverage Diff @@
## master #9207 +/- ##
========================================
- Coverage 81.0% 81.0% -0.1%
========================================
Files 276 276
Lines 60896 60928 +32
========================================
+ Hits 49365 49368 +3
- Misses 11531 11560 +29 |
jackcmay
force-pushed
the
rename-customerror
branch
from
b09e986 to
528ab8d
Compare
jstarry
reviewed
Apr 1, 2020
| @@ -116,7 +116,7 @@ pub enum InstructionError { | |||
| /// by the Solana runtime. A program-specific error may be any type that is represented as | |||
| /// or serialized to a u32 integer. | |||
| #[error("program error: {0:#x}")] | |||
| CustomError(u32), | |||
| Custom(u32), | |||
There was a problem hiding this comment.
the error message above says "program error", should we rename Custom to Program?
There was a problem hiding this comment.
Never mind, I think Custom makes more sense.
nit: how about updating the error message to "custom program error"?
jstarry
previously approved these changes
Apr 1, 2020
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 30, 2020
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 30, 2020
CriesofCarrots
added a commit
that referenced
this pull request
May 1, 2020
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2020
* Add program_error conversions (#9203) * Rename CustomError to Custom (#9207) * More custom error rename (#9227) automerge * Remove librapay conflicts * Fix rebase Co-authored-by: Jack May <jack@solana.com> (cherry picked from commit 3aa52f9) # Conflicts: # programs/librapay/Cargo.lock # programs/librapay/src/librapay_transaction.rs # programs/move_loader/src/processor.rs # runtime/src/bank/mod.rs
CriesofCarrots
added a commit
that referenced
this pull request
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Redudent "Error" in
InstructionError::CustomErrorandProgramError::CustomErrorSummary of Changes
Rename it to
CustomFixes #