This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
v1.1 backport custom error rename #9826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
reviewed
Apr 30, 2020
CriesofCarrots
force-pushed
the
v1.1-backport-custom-error
branch
from
741da58 to
cc89883
Compare
Codecov Report
@@ Coverage Diff @@
## v1.1 #9826 +/- ##
=======================================
- Coverage 80.7% 80.6% -0.1%
=======================================
Files 281 281
Lines 63768 63800 +32
=======================================
- Hits 51487 51479 -8
- Misses 12281 12321 +40 |
|
@jackcmay , does this look good now? |
|
lgtm |
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2020
* Add program_error conversions (#9203) * Rename CustomError to Custom (#9207) * More custom error rename (#9227) automerge * Remove librapay conflicts * Fix rebase Co-authored-by: Jack May <jack@solana.com> (cherry picked from commit 3aa52f9) # Conflicts: # programs/librapay/Cargo.lock # programs/librapay/src/librapay_transaction.rs # programs/move_loader/src/processor.rs # runtime/src/bank/mod.rs
CriesofCarrots
added a commit
that referenced
this pull request
May 1, 2020
solana-grimes
pushed a commit
that referenced
this pull request
May 1, 2020
mvines
added a commit
to mvines/solana
that referenced
this pull request
May 1, 2020
…na-labs#9838)" This reverts commit 2deebe4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove librapay merge-conflict artifacts, which offend my sensibilities