Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slashes redirect doesn't check existence of folder #42

Closed
michielbdejong opened this issue Dec 13, 2024 · 0 comments
Closed

Trailing slashes redirect doesn't check existence of folder #42

michielbdejong opened this issue Dec 13, 2024 · 0 comments

Comments

@michielbdejong
Copy link
Collaborator

The current implementation of #4 doesn't check whether the folder exists.
In hindsight I'm not so happy with that choice. I would like to give the PivotResponseWriter a way to check whether the folder exists in the storage, and only do the redirect if it does.
This will expose some information, but I think it's still a better option than serving redirects when the 401/403/404 response cannot be resolved by following those redirects.
A stretch goal would be to also check access; maybe that can be done with a rewrite of the DPoP Verifier, but we may have to leave that as room for future improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant