Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 6 compat #498

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Vite 6 compat #498

merged 6 commits into from
Dec 4, 2024

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Nov 27, 2024

Related to:

This PR

This PR updates all the deps to their latest, including the upgrade to Vite 6.

The only migration change needed is the resolve.conditions: https://vite.dev/guide/migration#default-value-for-resolve-conditions

I noticed there wasn't test CI, which I found unusual, so I added that in another PR:

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 9a5e350

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@birkskyum birkskyum changed the title Update everything else than Vite Vite 6 support Nov 27, 2024
@birkskyum birkskyum changed the title Vite 6 support Vite 6 compat Nov 27, 2024
@ryansolid
Copy link
Member

I don't think this is minor because it vite only impacts the building of this repo. But I'm good with all the changes. So I will adjust accordingly.

@ryansolid ryansolid merged commit 60693c9 into solidjs:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants