Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vite 6 example and peer deps compat #166

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Nov 26, 2024

Closes #165

Add vite 6 as option in peer deps

Add vite 6 example

Updates the vite 6 in root package.json, because it's now possible with a new version of vitefu:

These changes plays nicely with

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 1a527e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-solid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@birkskyum birkskyum mentioned this pull request Nov 26, 2024
@ryansolid
Copy link
Member

Assuming this all builds I'm good with this.

@birkskyum
Copy link
Contributor Author

It does, I ran vite dev earlier, but just now ran vite build + vite preview on all four versions

@ryansolid ryansolid merged commit 9c4ce8b into solidjs:main Nov 26, 2024
@ryansolid
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 6 compat
2 participants