Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solidus_easypost file #32

Merged
merged 5 commits into from
Feb 10, 2019

Conversation

peterberkenbosch
Copy link
Contributor

@peterberkenbosch peterberkenbosch commented Jan 30, 2019

the extension is expected to have a solidus_easypost file to load the
engine and other libraries. This commit introduces that file that is
a simple wrapper around the existing spree_easypost file.

This fixes the problem with not loading migrations. ( fixes #30 )

Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, @peterberkenbosch ! 🙌

But I have a few questions:

  • Wouldn't it be better if we renamed this file accordingly?

  • If that's the case, shouldn't we rename the folder spree_easypost under lib/ too?

  • It seems that this extension is missing a version.rb file under lib/spree_easypost/, what do you think about adding said file on this PR as well?

@peterberkenbosch
Copy link
Contributor Author

yes, I agree @aitbw, this was the quick fix mode but the best is to rename it. I'll add the version file too.

@gildardoperez
Copy link

@peterberkenbosch OMG. Awesome! Thank you!

@peterberkenbosch
Copy link
Contributor Author

@aitbw renamed all and introduced version file. Decided to go to a 2.0 version since we renamed it and this would be a breaking change.

Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, @peterberkenbosch ❤️ 👏 thanks a lot for this patch! 🙇‍♀️

@aitbw
Copy link
Contributor

aitbw commented Jan 31, 2019

What do you think on this, @kennyadsl @jacobherrington ?

README.md Outdated Show resolved Hide resolved
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterberkenbosch, just left a suggestion 👍

solidus_easypost.gemspec Outdated Show resolved Hide resolved
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aitbw
Copy link
Contributor

aitbw commented Feb 4, 2019

Let's wait to reach (and fix) a consensus on solidusio/solidus#3074 before merging this.

@aitbw
Copy link
Contributor

aitbw commented Feb 6, 2019

Re-running specs now that solidusio/solidus#3078 and solidusio/solidus#3079 are merged.

@peterberkenbosch
Copy link
Contributor Author

I will rebase this on master when #33 is merged. Thanks @aitbw

@aitbw
Copy link
Contributor

aitbw commented Feb 7, 2019

Done with #33, @peterberkenbosch 👌

the extension is expected to have a solidus_easypost file to load the
engine and other libraries. This commit introduces that file that is
a simple wrapper around the existing spree_easypost file.

This fixes the problem with not loading migrations.
@aitbw
Copy link
Contributor

aitbw commented Feb 8, 2019

Re-running specs due to a Travis failure.

@aitbw aitbw merged commit 9f5f6af into solidusio-contrib:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rake railties:install:migrations
5 participants