Use dynamic attributes on factories [v2.6] #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory_bot is now flagging static factory attributes as deprecated, pending removal in version 5.0.
4 tasks
This fixes the flaky spec described into solidusio#2910. Capybara fill_in sometime does not fill the input with the whole string. This commit will fill it with js bypassing the default behavior.
kennyadsl
approved these changes
Feb 6, 2019
This was referenced Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solidus extensions for versions 2.5 and 2.6 are broken because, when running
bundle, they're installingFactoryBotv5.0, which has removed static completely (see announcement here)This PR cherry-picks the changes introduced by @fastjames in #2831 in order to fix this inconvenience.
Ref: #3074
Checklist: