Merge pull request #1753 from jhawthorn/js_namespaces

Create JS namespaces in centralized file

backend/app/assets/javascripts/spree/backend.js

@@ -13,6 +13,7 @@
 //= require solidus_admin/bootstrap
 //= require prism
 //= require spree
+//= require spree/backend/namespaces
 //= require spree/backend/translation
 //= require spree/backend/backbone-overrides
 //= require spree/backend/spree-select2

backend/app/assets/javascripts/spree/backend/collections/line_items.js

@@ -1,7 +1,5 @@
 //= require spree/backend/models/line_item
 
-Spree.Collections = (Spree.Collections || {})
-
 Spree.Collections.LineItems = Backbone.Collection.extend({
   model: Spree.Models.LineItem,
 

backend/app/assets/javascripts/spree/backend/models/line_item.js

@@ -1,7 +1,5 @@
 //= require spree/backend/routes
 
-Spree.Models = (Spree.Models || {})
-
 Spree.Models.LineItem = Backbone.Model.extend({
   initialize: function(options) {
     this.order = this.collection.parent;

backend/app/assets/javascripts/spree/backend/models/order.js

@@ -1,8 +1,6 @@
 //= require spree/backend/routes
 //= require spree/backend/collections/line_items
 
-Spree.Models || (Spree.Models = {});
-
 Spree.Models.Order = Backbone.Model.extend({
   urlRoot: Spree.routes.orders_api,
   idAttribute: "number",

backend/app/assets/javascripts/spree/backend/namespaces.js

@@ -0,0 +1,8 @@
+_.extend(window.Spree, {
+  Models: {},
+  Collections: {},
+  Views: {
+    Order: {},
+    Cart: {}
+  }
+})

backend/app/assets/javascripts/spree/backend/views/cart/add_line_item_button.js

@@ -1,6 +1,3 @@
-Spree.Views = (Spree.Views || {})
-Spree.Views.Cart = (Spree.Views.Cart || {})
-
 Spree.Views.Cart.AddLineItemButton = Backbone.View.extend({
   initialize: function() {
     this.listenTo(this.collection, 'update', this.render);

backend/app/assets/javascripts/spree/backend/views/cart/line_item_row.js

@@ -1,6 +1,3 @@
-Spree.Views = (Spree.Views || {})
-Spree.Views.Cart = (Spree.Views.Cart || {})
-
 Spree.Views.Cart.LineItemRow = Backbone.View.extend({
   tagName: 'tr',
   className: 'line-item',

backend/app/assets/javascripts/spree/backend/views/cart/line_item_table.js

@@ -1,6 +1,3 @@
-Spree.Views = (Spree.Views || {})
-Spree.Views.Cart = (Spree.Views.Cart || {})
-
 Spree.Views.Cart.LineItemTable = Backbone.View.extend({
   initialize: function() {
     this.listenTo(this.collection, 'add', this.add);

backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js

@@ -1,6 +1,3 @@
-Spree.Views = (Spree.Views || {})
-Spree.Views.Order = (Spree.Views.Order || {})
-
 Spree.Views.Order.DetailsAdjustments = Backbone.View.extend({
   initialize: function() {
     this.listenTo(this.model, "change", this.render);

backend/app/assets/javascripts/spree/backend/views/order/details_total.js

@@ -1,6 +1,3 @@
-Spree.Views = (Spree.Views || {})
-Spree.Views.Order = (Spree.Views.Order || {})
-
 Spree.Views.Order.DetailsTotal = Backbone.View.extend({
   initialize: function() {
     this.listenTo(this.model, "change", this.render);

backend/app/assets/javascripts/spree/backend/views/order/summary.js

@@ -1,6 +1,3 @@
-Spree.Views || (Spree.Views = {});
-Spree.Views.Order || (Spree.Views.Order = {});
-
 Spree.Views.Order.Summary = Backbone.View.extend({
   initialize: function () {
     this.listenTo(this.model, "change", this.render);