Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JS namespaces in centralized file #1753

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Create JS namespaces in centralized file #1753

merged 1 commit into from
Mar 6, 2017

Conversation

jhawthorn
Copy link
Contributor

As suggested by @tvdeyen

This avoids the need to cautiously prefix files with lines like:

Spree.Models = (Spree.Models || {})

@jhawthorn
Create JS namespaces in centralized file
6610c5c 
This avoids the need to cautiously prefix files with lines like:

    Spree.Models = (Spree.Models || {})
tvdeyen
tvdeyen approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻 nice

@jhawthorn jhawthorn merged commit 15928c6 into solidusio:master Mar 6, 2017
@jhawthorn jhawthorn deleted the js_namespaces branch March 6, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @tvdeyen