Merge pull request #3673 from jacquesporveau/jacquesporveau/stock_mov…

…ements_admin

Display originator email in stock movement admin

backend/app/helpers/spree/admin/stock_movements_helper.rb

@@ -4,12 +4,16 @@ module Spree
   module Admin
     module StockMovementsHelper
       def pretty_originator(stock_movement)
-        if stock_movement.originator.respond_to?(:number)
-          if stock_movement.originator.respond_to?(:order)
-            link_to stock_movement.originator.number, [:edit, :admin, stock_movement.originator.order]
+        originator = stock_movement.originator
+
+        if originator.respond_to?(:number)
+          if originator.respond_to?(:order)
+            link_to originator.number, [:edit, :admin, originator.order]
           else
-            stock_movement.originator.number
+            originator.number
           end
+        elsif originator.respond_to?(:email)
+          originator.email
         else
           ""
         end

backend/spec/helpers/admin/stock_movements_helper_spec.rb

@@ -11,15 +11,23 @@
     subject { helper.pretty_originator(stock_movement) }
 
     context "originator has a number" do
-      let(:originator) { create(:order) }
+      let(:originator) { build(:order) }
 
       it "returns the originator's number" do
         expect(subject).to eq originator.number
       end
     end
 
-    context "originator doesn't have a number" do
-      let(:originator) { create(:user) }
+    context "originator has an email" do
+      let(:originator) { build(:user, email: "stock_mover@example.com") }
+
+      it "returns the originator's email" do
+        expect(subject).to eq "stock_mover@example.com"
+      end
+    end
+
+    context "the stock movement doesn't have an originator" do
+      let(:originator) { nil }
 
       it "returns an empty string" do
         expect(subject).to eq ""