Display originator email in stock movement admin #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building these instances instead of persisting to the database will speed up the spec suite and they do not need to be persisted.
I think ideally the #pretty_originator method doesn't even take a stock movement but rather a originator since we never actually operate on the stock movement but I don't want to step that far so for now I will just save the originator as a variable so we can cut down on the amount of code someone working here needs to read/comprehend.
Previously on the stock movements page if a stock movement was originated by a user then we would not display any information about the originator. This commit alters that interface to display the users email address.
jarednorman
approved these changes
Jun 20, 2020
kennyadsl
approved these changes
Jun 22, 2020
|
Thank you @jacquesporveau, there's an unrelated failing spec that we need to take a look at but I think this is safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gets #3666 started.
From the issue:
This PR is meant to remedy that trouble.
One point that might be worth discussing is whether or not we should link to the actual user. I think it would be kind of difficult to figure out whether the originator is a user unless we do a class check and I think those are not in favour.
Since we can't really figure out if the originator is a user then providing a link in the admin to the originator becomes difficult. It may be worth going after the most common use case which is that if the originator responds to email then it's probably a
Spree::Userand we could do another conditional and provide a link if it's a user.Let me know what you think!
Screenshot:
Checklist: