Merge pull request #3647 from seand7565/add_factory_bot_linting

Add factory_bot lint test to core

core/lib/spree/testing_support/factories/store_credit_event_factory.rb

@@ -8,6 +8,7 @@
     store_credit
     amount             { 100.00 }
     authorization_code { "#{store_credit.id}-SC-20140602164814476128" }
+    action               { Spree::StoreCredit::AUTHORIZE_ACTION }
 
     factory :store_credit_auth_event, class: 'Spree::StoreCreditEvent' do
       action             { Spree::StoreCredit::AUTHORIZE_ACTION }

core/lib/spree/testing_support/factories/store_credit_reason_factory.rb

@@ -2,6 +2,8 @@
 
 FactoryBot.define do
   factory :store_credit_reason, class: 'Spree::StoreCreditReason' do
-    name { "Input error" }
+    sequence :name do |n|
+      "Input error #{n}"
+    end
   end
 end

core/spec/lib/factory_spec.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe "Factories" do
+  it "should pass linting" do
+    FactoryBot.lint(FactoryBot.factories.reject{ |f| f.name == :customer_return_without_return_items })
+  end
+end