Add factory_bot lint test to core #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 30, 2020
seand7565
force-pushed
the
add_factory_bot_linting
branch
from
388a336 to
83d8889
Compare
jarednorman
reviewed
Jun 1, 2020
There was a problem hiding this comment.
Do we want this as part of our RSpec core tests or do we want it as a separate task? I don't have a particular opinion either way, but I thought it worth considering.
Side note: I'm going to refrain from approving this PR since technically I sponsored it, even though @seand7565 selected this task himself.
aldesantis
requested changes
Jun 2, 2020
|
I think it's okay for this to be part of the test suite, just left a couple of minor comments! |
Adds a test that lints FactoryBot. Also makes changes to two tests to conform to the lint - store_credit_event_factory needs to have an action, even if the action is replaced with one of the sub factories. store_credit_reason_factory tripped the linter because of a uniqueness contraint for the name - should not come up in normal testing, but I added a sequencer to account for it in the linter anyway. The linter ignores just one factory - customer_return_without_return_items this factory is intentionally invalid (see: /core/spec/lib/spree/core/testing_support/factories/customer_return_factory_spec.rb#L37 )
seand7565
force-pushed
the
add_factory_bot_linting
branch
from
83d8889 to
92a5e3b
Compare
aldesantis
approved these changes
Jun 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR SPONSORED BY Super Good Software
Description
Adds a test that lints FactoryBot. Also makes changes to two tests to
conform to the lint - store_credit_event_factory needs to have an
action, even if the action is replaced with one of the sub factories.
store_credit_reason_factory tripped the linter because of a uniqueness
contraint for the name - should not come up in normal testing, but I
added a sequencer to account for it in the linter anyway.
The linter ignores just one factory - customer_return_without_return_items
this factory is intentionally invalid (see:
customer_return_factory_spec.rb
).. though I think we should re-evaluate that, maybe open an issue for changing it.
This PR is attempting to close (at the time of writing) the oldest issue for Solidus, #568
Checklist: