Merge pull request #2227 from ccarruitero/cleanup

remove unused update_params_payment_source method
solidusio · Sep 29, 2017 · aab557d · aab557d
2 parents 9cfc15f + 5389c70
commit aab557d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb
@@ -794,6 +794,7 @@ def update_params_payment_source
         @updating_params[:order][:payments_attributes].first[:amount] = total
       end
     end
+    deprecate update_params_payment_source: :set_payment_parameters_amount, deprecator: Spree::Deprecation
 
     def associate_store
       self.store ||= Spree::Store.default

diff --git a/core/spec/models/spree/order_spec.rb b/core/spec/models/spree/order_spec.rb
@@ -1538,4 +1538,14 @@ def generate
       end
     end
   end
+
+  context 'update_params_payment_source' do
+    subject { described_class.new }
+
+    it 'is deprecated' do
+      subject.instance_variable_set('@updating_params', {})
+      expect(Spree::Deprecation).to receive(:warn)
+      subject.update_params_payment_source
+    end
+  end
 end