remove unused update_params_payment_source method #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for this. However, we don't just delete methods like that. Please deprecate it, and we can remove it in a future version. People might have used this method in their host apps, and just removing it without a warning would be a terrible dev experience. |
ccarruitero
force-pushed
the
cleanup
branch
from
382761e to
e2afdbb
Compare
houndci-bot
reviewed
Sep 19, 2017
core/app/models/spree/order.rb
Outdated
| @@ -782,11 +782,12 @@ def process_payments_before_complete | |||
| # } | |||
| # | |||
| def update_params_payment_source | |||
| if @updating_params[:order] && (@updating_params[:order][:payments_attributes] || @updating_params[:order][:existing_card]) | |||
| if @updating_params&[:order] && (@updating_params&[:order]&[:payments_attributes] || @updating_params&[:order]&[:existing_card]) | |||
There was a problem hiding this comment.
Surrounding space missing for operator &.
mtomov
reviewed
Sep 20, 2017
core/app/models/spree/order.rb
Outdated
| @@ -782,11 +782,12 @@ def process_payments_before_complete | |||
| # } | |||
| # | |||
| def update_params_payment_source | |||
| if @updating_params[:order] && (@updating_params[:order][:payments_attributes] || @updating_params[:order][:existing_card]) | |||
| if @updating_params&[:order] && (@updating_params&[:order]&[:payments_attributes] || @updating_params&[:order]&[:existing_card]) | |||
There was a problem hiding this comment.
Better figure out how to set some dummy data to this instance variable @updating_params in the test rather than changing the method. Given that it hasn't been tested so far, any change can break it really.
ccarruitero
force-pushed
the
cleanup
branch
from
e2afdbb to
5389c70
Compare
cbrunsdon
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was moved from
Spree::Order::Checkout, and seems to be unused now that we useset_payment_parameters_amountmethod for the same.