Merge pull request #2130 from melissacarbone/ensure_validation_errors…

…_are_returned_for_refund

Ensure validation error is returned when creating a refund without a …

core/app/models/spree/refund.rb

@@ -76,7 +76,7 @@ def create_log_entry
     end
 
     def amount_is_less_than_or_equal_to_allowed_amount
-      if amount > payment.credit_allowed
+      if payment && amount > payment.credit_allowed
         errors.add(:amount, :greater_than_allowed)
       end
     end

core/spec/models/spree/refund_spec.rb

@@ -160,6 +160,14 @@
         }
       end
     end
+
+    context 'when payment is not present' do
+      let(:refund) { build(:refund, payment: nil) }
+
+      it 'returns a validation error' do
+        expect { refund.save! }.to raise_error 'Validation failed: Payment can\'t be blank'
+      end
+    end
   end
 
   describe 'total_amount_reimbursed_for' do