Validate that Refunds have an associated Payment #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammathys
approved these changes
Aug 2, 2017
melissacarbone
force-pushed
the
ensure_validation_errors_are_returned_for_refund
branch
from
f66ee93 to
256cf4a
Compare
jhawthorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…payment
Without this change, when a refund is saved with no payment it raises:
NoMethodError: undefined method `credit_allowed' for nil:NilClassfrom:
app/models/spree/refund.rb:77:in `amount_is_less_than_or_equal_to_allowed_amount'