Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The navigation menu should be a collapsible #2961

Closed
5 tasks
jacobherrington opened this issue Nov 20, 2018 · 10 comments · Fixed by #3322
Closed
5 tasks

The navigation menu should be a collapsible #2961

jacobherrington opened this issue Nov 20, 2018 · 10 comments · Fixed by #3322
Labels
changelog:solidus_backend Changes to the solidus_backend gem

Comments

@jacobherrington
Copy link
Contributor

This is a continuation of #666 based on feedback from an MVP attempt at this functionality in #2957 and the earlier work done in #1718.

One of the more pressing issues with Solidus' admin UI is a lack of responsiveness. A key step in achieving a more responsive, modern feeling UI is recovering some lost screen real estate by reworking the navigation menu.

Ideally, the navigation menu could be collapsed much like the navigation menu in GitLab and Spree:

screen shot 2018-11-20 at 4 27 39 pm

Some of the requirements laid down in previous issues and discussions:

  • Default open on large screens.
  • Default close on small screens.
  • Remember user preferences on the computer/device they're using.
  • Stays open/close until user changes the preference.
  • Label on collapsed nav items to appear on hover. Tooltip should look consistent with admin, but different from menu styles.

An example mockup:

image

@jacobherrington
Copy link
Contributor Author

I am currently working on this, but would love to take suggestions here!

@tvdeyen
Copy link
Member

tvdeyen commented Nov 21, 2018

I have a branch with a working prototype as well. Just tell me if I should send it to you.

@jacobherrington
Copy link
Contributor Author

@tvdeyen sure! That'd be a big help, thanks!

@jacobherrington jacobherrington added UI changelog:solidus_backend Changes to the solidus_backend gem labels Nov 21, 2018
@tvdeyen
Copy link
Member

tvdeyen commented Nov 21, 2018

@jacobherrington https://github.com/tvdeyen/solidus/tree/collapsible-nav

jacobherrington added a commit to jacobherrington/solidus that referenced this issue Feb 2, 2019
This commit adds a method for hiding the sidebar to recover some screen
real estate. As described in issue solidusio#2961
@seand7565
Copy link
Contributor

@jacobherrington If you're not still working on this I'd love to take a crack at finishing it - this is a feature I'd love to see in the next release.

@jacobherrington
Copy link
Contributor Author

@seand7565 Please do, I haven't had much free time in the last few months. 👍

@tvdeyen
Copy link
Member

tvdeyen commented Apr 2, 2019

@seand7565 this would be great 👍

@seand7565
Copy link
Contributor

Great! I've started working on it here -> https://github.com/seand7565/solidus/tree/nav-collapse

@jacobherrington
Copy link
Contributor Author

@seand7565 Please let me know if I can help, I don't have much time, but happy to give feedback. Thanks Sean! 🥇

@jacobherrington
Copy link
Contributor Author

#3322 Work is being done in this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants