-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/make admin more responsive #2863
Chore/make admin more responsive #2863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for me without a <meta name="viewport" content="width=device-width, initial-scale=1">
tag
@tvdeyen added a viewport tag. Should be useful if we want to make admin mobile friendly. |
@jacobherrington please take a look at this issue and this closed PR also. We started some work for the collapsible menu but, the way it was required to be, it turned out to be a big change. At the moment I think we need something more simple, like removing the ability to expand/reduce the menu in mobile/desktop. |
@kennyadsl Ah, well this PR isn't doing that quite yet. Instead this PR just makes some of the forms collapse on smaller window sizes. I will read through those threads if I get to a sidenav PR! Thanks for the info! |
@jacobeubanks sorry, my bad. Now with the meta tag the admin does not scale any more on small devices. This is an issue for all tablet users, as long as we don't collapse the sidebar as well. I think we should fix that sidebar problem before we take care of the rest. |
Sounds good @tvdeyen. I will look into that! |
Closing this until we have a resolved #2961, then I will revisit a more complete version of this. |
This PR adds Bootstrap breakpoints to most of the forms in the admin area.
A good next step would be making the sidebar animated on mobile resolutions, but that's a more drastic change.
This probably needs to be squashed if everyone is okay with the change.