Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/make admin more responsive #2863

Conversation

jacobherrington
Copy link
Contributor

@jacobherrington jacobherrington commented Sep 24, 2018

This PR adds Bootstrap breakpoints to most of the forms in the admin area.

A good next step would be making the sidebar animated on mobile resolutions, but that's a more drastic change.

This probably needs to be squashed if everyone is okay with the change.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for me without a <meta name="viewport" content="width=device-width, initial-scale=1"> tag

@jacobherrington
Copy link
Contributor Author

jacobherrington commented Sep 24, 2018

@tvdeyen added a viewport tag. Should be useful if we want to make admin mobile friendly.

@kennyadsl
Copy link
Member

@jacobherrington please take a look at this issue and this closed PR also. We started some work for the collapsible menu but, the way it was required to be, it turned out to be a big change.

At the moment I think we need something more simple, like removing the ability to expand/reduce the menu in mobile/desktop.

@jacobherrington
Copy link
Contributor Author

@kennyadsl Ah, well this PR isn't doing that quite yet. Instead this PR just makes some of the forms collapse on smaller window sizes.

I will read through those threads if I get to a sidenav PR! Thanks for the info!

@tvdeyen
Copy link
Member

tvdeyen commented Sep 24, 2018

@jacobeubanks sorry, my bad. Now with the meta tag the admin does not scale any more on small devices. This is an issue for all tablet users, as long as we don't collapse the sidebar as well. I think we should fix that sidebar problem before we take care of the rest.

@jacobherrington
Copy link
Contributor Author

Sounds good @tvdeyen. I will look into that!

@jacobherrington
Copy link
Contributor Author

Closing this until we have a resolved #2961, then I will revisit a more complete version of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants