Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize i18n keys #3978

Closed
kennyadsl opened this issue Mar 5, 2021 · 2 comments · Fixed by #4437
Closed

Normalize i18n keys #3978

kennyadsl opened this issue Mar 5, 2021 · 2 comments · Fixed by #4437

Comments

@kennyadsl
Copy link
Member

i18n-tasks gem now comes with the following post-install message:

Post-install message from i18n-tasks:
# Install default configuration:
cp $(bundle exec i18n-tasks gem-path)/templates/config/i18n-tasks.yml config/
# Add an RSpec for missing and unused keys:
cp $(bundle exec i18n-tasks gem-path)/templates/rspec/i18n_spec.rb spec/

It's a good opportunity to follow these instructions and improve i18n in our platform. I tried and there are a couple of things to configure and fix, but in general, it would be great to have the suggested specs to run in the CI.

@sriddbs
Copy link

sriddbs commented Jun 7, 2021

@kennyadsl I would like to take this up, can you please assign this to me and provider some pointers on how to begin

@kennyadsl
Copy link
Member Author

Hey @sriddbs, no need to assign this you can submit the PR directly. I have no more details other than what I posted in the description. This task requires an exploratory phase to understand what those tasks do and how we could benefit from them.

Thanks for contributing!

Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 29, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
Hakeemmidan added a commit to Hakeemmidan/solidus that referenced this issue Jun 30, 2021
waiting-for-dev pushed a commit to nebulab/solidus that referenced this issue Jun 22, 2022
i18n-tasks gem helps in managing translations. For now we don't use the
tasks in our test pipeline. Added config and test for `api/` and
`core/`.

Signed-off-by: Shubham Pandey <shubham9411@gmail.com>
waiting-for-dev pushed a commit that referenced this issue Jun 22, 2022
i18n-tasks gem helps in managing translations. For now we don't use the
tasks in our test pipeline. Added config and test for `api/` and
`core/`.

Signed-off-by: Shubham Pandey <shubham9411@gmail.com>
waiting-for-dev pushed a commit that referenced this issue Jun 23, 2022
i18n-tasks gem helps in managing translations. For now we don't use the
tasks in our test pipeline. Added config and test for `api/` and
`core/`.

Signed-off-by: Shubham Pandey <shubham9411@gmail.com>
waiting-for-dev added a commit that referenced this issue Aug 16, 2022
Sanitize i18n keys using i18n-tasks gem issue: #3978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants