Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing zeroes in tax amount #4757

Closed
wants to merge 1 commit into from
Closed

remove trailing zeroes in tax amount #4757

wants to merge 1 commit into from

Conversation

Naokimi
Copy link
Contributor

@Naokimi Naokimi commented Dec 1, 2022

  • Deprecate SolidusFrontend
  • Fix working with nested option values through option types in the API
  • Add image preference spec test
  • Update guides to recommend image style settings
  • Add libvips to requirement as imagemagick alternative
  • Add missing link to brew
  • Fix: common:test_app should change Rails.env to test
  • Extract force_rails_environment_to_test
  • Remove wrong definition of :option_values_attributes for variants
  • Fix deprecation of active payment methods
  • Update README.md chromedriver link
  • Formatting: Put money methods on a line each
  • Add spec for line item total before tax
  • Add Spree::Order#shipment_total_before_tax
  • Add more money methods
  • Skip failing test because of unsupported feature on Rails < 6.1
  • Fail with raise when the storage adapter is not supported
  • Add tax_category_id to variant's permitted attributes
  • Update CircleCI configuration
  • Fix delete response in admin users controller
  • Fix preloading of orders in admin users controller
  • Remove N+1 from admin users table
  • Fix Order#tax_address method
  • Fix inconsistency in ReturnItem#inventory_unit validation
  • Sanitize i18n keys using i18n-tasks gem issue: Normalize i18n keys #3978
  • Add global Spree::Config.default_email_regexp
  • Refactor and add specs to stock locations helper
  • Deprecate try_spree_current_user
  • Migrate all uses of try_spree_current_user to spree_current_user
  • Deprecate Ruby 2.5 & Ruby 2.6
  • Deprecate Rails 5.2
  • Fix Country factory states_required attribute
  • Wrap address_factory_spec in a context
  • Use nested Carmen regions if necessary for state factory
  • Automatically create a state if necessary for address factory
  • Make the inventory unit builder configurable
  • Make the availability validator configurable
  • Make the inventory validator configurable
  • Ensure removal of constants in specs
  • Recalculate promotions after destroying/refreshing shipments
  • Permit Symbol for safe load
  • Permit BigDecimal for safe load
  • Permit ActiveSupport::HashWithIndifferentAccess for safe load
  • Avoid persisting Spree::Role objects as UserRole role IDs
  • Set yaml_column_permitted_classes only if it defined
  • Require psych to be >= 3.1.0
  • Support code reloading when configuring static preferences sources
  • Document changes about how to configure sources for static preferences
  • Fix stores with no authentication
  • Move legacy guides to a separate repository
  • Remove guides-specific CircleCI configuration
  • Remove guides-specific RuboCop configuration
  • Update PR template
  • Fix Gemfile order dependency solidus_frontend <> solidus_auth_devise
  • Fix Gemfile order dependency solidus_backend <> solidus_auth_devise
  • Allow to extend user deletion logic
  • Add order-level tax support to OrderTax
  • Fix incorrect validation message
  • Apply order-level taxes in OrderTaxation
  • Update aggregate columns with order-level taxes
  • Extract Spree::Admin::SetsUserLanguageLocaleKey
  • Skip admin authorization for Admin::LocaleController#set
  • Include discarded prices in delete_prices_with_nil_amount task
  • Remove PayPal as an option during the installation process
  • Switch orders bill address search to use contains instead of starts with
  • Add explicit information about DB_* env variables to the README (Add explicit information about DB_* env variables to the README #4461)
  • Deprecate solidus_frontend & allow installing solidus_starter_frontend
  • Update README with solidus_starter_frontend info
  • Remove frontend directory
  • Fix bad MySQL package in Dockerfile
  • Remove unneeded source: argument when adding solidus_frontend
  • Do not break down meta-gem when solidus_frontend is chosen
  • Fix installer when a custom source is given
  • Fix installer when solidus is fetched from git
  • Acknowledge ignored options when breaking down Solidus
  • Add missing country names for en locale
  • Translate country name in Spree::Price#display_country
  • Run auth generator when starter frontend installs the gem
  • Use translated country select in Store edit form
  • Fix key in the locale file
  • Add eligibility check to free shipping action
  • Prepare Changelog for v3.2
  • Update previous minor version
  • Prepare for v3.3
  • Use GH actions to automatically label changes
  • Remove duplicated attributes from API docs
  • Simulate a validation error on LegacyUser and restore spec
  • Restore SQLite specs that were previously skipped
  • Avoid the "already initialized constant" warnings with net/ libraries
  • Suppress AR migration output inside specs
  • Improve error messages for a misconfigured test DB
  • Add sqlite executor to CI
  • Implemented fix for FileNotFound errors with Active Storage This commit adds the ability for the application to catch missing images with Active Storage during an API call should a file become corrupt or deleted without removing the record through appropriate channels. This compliments PR Rescue FileNotFoundError exception on failed image downloads #4026 which prevented the same error on the backend. The change will return and image with attributes equal to nil and noimage replacements if an image cannot be sourced.
  • Add missing GH Actions workflow for labeler
  • Remove the frontend group from the Gemfile
  • Don't bundle the "utils" group in the CI
  • Remove jruby support from the Gemfile
  • Simplify the database gem setup in the gemfile
  • Don't load yard unless the task is being run
  • Only default to activestorage adapter if Rails version is supported
  • Let bin/rspec automatically detect the subdirectory in which the spec lives
  • Extract Promotion Adjusting from OrderUpdater
  • Provide extension point for promotion adjuster class
  • Copy logic from Spree::Adjustment to OrderAdjustmentsRecalculator
  • Move order and item total calculation to OrderAdjustmentsRecalculator
  • Add Documentation to Spree::Promotion::OrderAdjustmentsRecalculator
  • Delegate --auto-accept installer option to solidus_frontend
  • Don't remove non-accessible roles when assigning new accessible roles
  • Update Changelog
  • Add coverage report badge using Codecov
  • Use fail/then instead of error/done From the jQuery upgrade guide:
  • Update deprecated method to #ajaxSetup
  • Deprecate #redirect_to_or_default Devise has a nearly identical method for storing a user's location and returning a path to navigate to. Deprecating to simplify the code base.
  • Add FlatFee tax calculator
  • Add level enum to TaxRates
  • Only apply item level taxes to items
  • Calculate order-level taxes in default
  • Add radio for Spree::TaxRate#level
  • Update translations for FlatFee tax calculator
  • Update tax rate amount explanation
  • Add rake task for Colorado Delivery Fee
  • Add explicit translation key for flat_fee taxes
  • Deprecate Spree::UserLastUrlStorer
  • Update Spec to force AJAX Error
  • Remove link to unmaintained docker demo
  • Add latest v3.0 and v3.1 releases to changelog
  • Streamline conditional appended to a heredoc
  • Fix forwarding arguments to solidus:install in bin/sandbox
  • Support debug output with the DEBUG env var in bin/sandbox
  • Install generator cleanup
  • Use the standard route helper for installing routes
  • Remove stoplight support from the CI config
  • Add a CI job for testing the installer with different options
  • Switch the install generator to AppBase to gain app:template style helpers
  • Forward :auto_accept and :migrate options to generator sub-commands
  • Let the installer handle the authentication while generating the sandbox
  • Move frontend installation recipes to local app templates
  • Add limited options to validate user input for the frontend
  • Cache the rubygems dir in the solidus installer CI job
  • Skip samples while testing the solidus installer in the CI
  • Add spec for Spree::Variant#on_backorder
  • Add spec for Spree::Variant#deleted?
  • Add spec for Spree::Variant#options=
  • Add spec for Spree::Variant#name_and_sku
  • Add spec for Spree::Variant#sku_and_options_text
  • Add spec for Variant#check_price validation
  • Default Spree.user_class to "LegacyUser"
  • Fix the indentation
  • Fix indentation with <<~
  • Suppress "Using ..." messages while running bundle install
  • Allow to skip the migration check with an env variable
  • Update link to solidus_frontend
  • Further specify param type for Spree::Variant#options=
  • Silence all migrations during installation
  • Fix the user table checks in api migrations
  • Add logs with sections to the sandbox script
  • Use thor shell to log seed and sample loading
  • Indent ruby code with squiggly heredoc
  • Fix occasional "database is locked" errors while loading sample data
  • Add a CI job for testing the dummy app generation
  • Call the solidus generator by shelling-out for the dummy app
  • Provide a meaningful message if ENV['LIB_NAME'] is not set
  • Don't add solidus_frontend if already in the Gemfile
  • Allow opting-in to a frontend other than solidus_frontend while generating the dummy app
  • Ensure the installer fails if anything goes wrong
  • Don't pass --payment-method to the installer for the dummy app
  • Update CHANGELOG.md
  • Do not discard prices upon variant deletion
  • Sort currently_valid_prices in Ruby
  • Use currently_valid_prices method for detecting default price
  • Fix products helper spec setup
  • Do not render price form for discarded products
  • Make sure the logs will state what is being installed
  • Extract the page testing script to its own CI command
  • Create a folder for all app_templates used during the installation
  • Sort prices in-memory in Variant::PriceSelector
  • Return to original currently_valid_prices and deprecate it
  • Remove unused shared examples for default price
  • Use Price Selector in Spree::Variant#default_price
  • Use app templates to install the authentication system
  • Skip the custom_user migration if the table doesn't exist
  • Move custom_user generator module inclusions to an initializer
  • Don't assume current_user is available in the custom_user generator
  • Add existing_devise as an authentication template
  • Move authentication handling after database creation
  • Deprecate --with-authentication in favor of --authentication
  • Update underscore.js
  • Maintain prices for previously soft-deleted variants
  • Add pagination to variant autocomplete
  • Format select2 "load more" indicator
  • [FIX] Emptying cart will update the order summary.
  • Use a matrix to test ruby/rails/database versions
  • Update bundler & rubygems in the CI
  • Shorten names for authentication options
  • Make --authentication=none the same as --with-authentication=false
  • Fix the slack badge in the README
  • Add ruby 2.5 and 2.6 to the CI matrix
  • Don't use net-http for ruby < 2.6
  • Install imagemagick on CI for ruby 2.5
  • Ensure puma 6 is not used
  • Don't pollute Object with a local helper method
  • Remove the legacy plugin support from solidus:install
  • Add a spec for the install generator options
  • From Rails 4.1 onward enforce_available_locales defaults to true
  • Deprecate the --lib-name option of the solidus installer
  • Handle robots.txt from frontend extensions
  • Remove typo from the migrations check message
  • Improve how questions are asked inside solidus:install
  • Extract running a template for a topic in solidus:install
  • Install frontend and authentication after running migrations
  • Reset gemfile info after every bundler command
  • Shorten the option names that need to be typed during installation
  • Typo: missing dot
  • Remove the dummy app support for parallel testing
  • GitHub Action to automatically create backport PRs
  • Don't install solidus_bolt unless requested
  • Add a test for default options to the installer
  • Remove unused source paths from the install generator
  • Declare all option instance variables together in the installer
  • Move auth seeds installation to the proper app-template
  • Be less defensive about loading seeds
  • Don't try to load samples without first running seeds
  • Add back the --payment-method option for solidus:install
  • Add back PayPal as the default payment method in the installer
  • Add Bolt as an alternative payment method option
  • Remove "Deploy to Heroku" Button from Readme
  • Add changelog entry for 2.11.17 release mentioning breaking change
  • Escape markdown character in comment
  • Add reusable action adjustment trait on Promotion factory
  • Refactor Promotion factory
  • Install and set up Buildkite Test Analytics
  • Assign option types to all clothing samples
  • Configure GitHub releases
  • Update guides link
  • Add v3.2.3 to the Changelog
  • Revert "Configure GitHub releases"
  • Remove typo from warning about solidus migration check
  • Do not pass arrays to can?
  • Revert jQuery Changes to Xhr Var in Image Upload
  • Add support for sorting store credits with different algorithms (Add support for sorting store credits with different algorithms #4677)
  • Update Changelog after v3.2.4 release
  • Deprecate unused Spree::Config#mails_from
  • Enable Stale Bot with parent org configuration
  • Remove useless health files and templates
  • Improve Spree::Order::NumberGenerator speed
  • Notify CI failures on Slack
  • Ignore big reformatting commits in GitHub blame UI
  • Remove trailing zeroes in tax amount

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

NumberToPercentageConverter defaults to a precision of 3, leading to
displays of VAT amount like '21.000%' on the cart's label, which doesn't
look good. Using `precision: nil` will keep the default precision of the
number.
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 1, 2022
@Naokimi Naokimi closed this Dec 1, 2022
@Naokimi Naokimi deleted the remove-trailing-zeroes-in-tax-amount branch December 1, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant