Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spree::Deprecator is not a valid constant in 2.11.5 #3990

Closed
tmtrademarked opened this issue Mar 12, 2021 · 1 comment · Fixed by #3991
Closed

Spree::Deprecator is not a valid constant in 2.11.5 #3990

tmtrademarked opened this issue Mar 12, 2021 · 1 comment · Fixed by #3991

Comments

@tmtrademarked
Copy link
Contributor

Running specs in 2.11.5 produces an error about an unknown constant. It appears that the core/lib/spree/testing_support.rb file has a bug and should be using a different syntax: https://github.com/solidusio/solidus/blame/master/core/lib/spree/testing_support.rb#L28. It appears that this was introduced in the 2.11.5 patch.

Solidus Version:
2.11.5

To Reproduce

  1. Update to 2.11.5
  2. Run rspec tests using bundle exec rspec

Current behavior

Failure/Error: require File.expand_path('../config/environment', __dir__)

NameError:
  uninitialized constant Spree::Deprecator
  Did you mean?  Spree::Deprecation
                 Delegator
# ./config/application.rb:102:in `block in <class:Application>'
# ./config/environment.rb:5:in `<top (required)>'
# ./spec/rails_helper.rb:8:in `require'
# ./spec/rails_helper.rb:8:in `<top (required)>'

Expected behavior
No errors. :-)

tmtrademarked added a commit to tmtrademarked/solidus that referenced this issue Mar 12, 2021
It looks like `Spree::Deprecator` reference added in 2.11.5 should have been `Spree::Deprecation` instead. This should fix solidusio#3990
@tmtrademarked
Copy link
Contributor Author

I think this PR should fix this problem: #3991

kennyadsl pushed a commit that referenced this issue Mar 16, 2021
It looks like `Spree::Deprecator` reference added in 2.11.5 should have been `Spree::Deprecation` instead. This should fix #3990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant