Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for incorrect deprecation class #3991

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix for incorrect deprecation class #3991

merged 1 commit into from
Mar 16, 2021

Conversation

tmtrademarked
Copy link
Contributor

@tmtrademarked tmtrademarked commented Mar 12, 2021 •
edited
Loading

It looks like Spree::Deprecator reference added in 2.11.5 should have been Spree::Deprecation instead. This should fix #3990

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@tmtrademarked
Fix for incorrect deprecation class
224463e 
It looks like `Spree::Deprecator` reference added in 2.11.5 should have been `Spree::Deprecation` instead. This should fix solidusio#3990
@tmtrademarked
Copy link
Contributor Author

Hmm - I can't re-run the tests, but it looks like it was failing in something unrelated.

@tmtrademarked tmtrademarked mentioned this pull request Mar 12, 2021
Closed
aldesantis
aldesantis approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@aldesantis aldesantis requested a review from a team March 14, 2021 09:13
@kennyadsl
Copy link
Member

Re-running specs, I'm going to backport and release 2.11.6 later today or tomorrow, thanks!

@kennyadsl kennyadsl added the type:bug Error, flaw or fault label Mar 15, 2021
@kennyadsl kennyadsl added this to the 2.11 milestone Mar 15, 2021
@kennyadsl kennyadsl merged commit a9a7a95 into solidusio:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Spree::Deprecator is not a valid constant in 2.11.5
4 participants
@tmtrademarked @kennyadsl @aldesantis @jarednorman