Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clear cache button #1275

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Conversation

jhawthorn
Copy link
Contributor

Our current "General Settings" page has a "Clear cache" button.

On stores I've worked on I wouldn't want this exposed to admins. We should (and afaik we do) expire caches every time the underlying DB object is changed.

This is motivated partly because I want to replace the GeneralSettingsController with a StoreController, and this is the only thing on that page that doesn't directly relate to a store.

Though this should be trivial to replace in one's own store, I'd love to hear if anyone considers this important in their admin or would be inconvenienced by it being removed.

@jhawthorn jhawthorn added the changelog:solidus_backend Changes to the solidus_backend gem label Jun 27, 2016
@bbuchalter
Copy link
Contributor

We built our own clear cache button, but only developers used it. Eventually, we just built it into the deploy process. 👍 for removal.

@jhawthorn
Copy link
Contributor Author

Another point I should mention is that stores with heavy custom caching (which is who I assume this is designed for) are likely to need more than just Rails.cache.clear. The existing specs hint at this. It would be simpler for these stores just to implement their own cache clear button than to try and hack into this existing one.

@jasonfb
Copy link

jasonfb commented Jun 28, 2016

👍 for removing button. Only developers should need to do platform operations like clearing the Rails cache, and we have access to the Rails console for this. Too dangerous to give non-developers things they can mess things up with (we have enough problems with them creating Promos that break our checkout!)

@jhawthorn jhawthorn changed the title [RFC] Remove clear cache button Remove clear cache button Jun 28, 2016
@gmacdougall
Copy link
Member

👍

Our existing "General Settings" page has a "Clear cache" button.

On stores I've worked on I wouldn't want this exposed to admins. We
should (and afaik we do) expire caches every time the underlying DB
object is changed.

This is motivated partly because I want to replace the
GeneralSettingsController with a StoreController, and this is the only
thing on that page that doesn't directly relate to a store.
@jhawthorn jhawthorn force-pushed the remove_clear_cache branch from 49d900a to 9ead23f Compare June 30, 2016 21:33
@jhawthorn
Copy link
Contributor Author

Rebased and added note to changelog

@jhawthorn jhawthorn merged commit e88a701 into solidusio:master Jun 30, 2016
@jhawthorn jhawthorn deleted the remove_clear_cache branch June 30, 2016 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants