942 billing to default address #1424
Conversation
|
The fix is really good, especially coupled with #1967 - just cherry-picked both, and about to deploy them to production. It is indeed great to have this usability improvement. Thanks for the fix @yeonhoyoon , and taking it up afterwards @peterberkenbosch ! |
|
@tvdeyen I know you fixed this in a client project, do you agree this works well? |
|
@peterberkenbosch there is a conflict, could you please resolve? @mamhoff no, that wasn't me, but this change here is great |
Set `bill_address` to default address, if user has one. Currently when order goes to `address` state, only ship address gets filled in from a previously entered address. This is because `ship_address` is set to default address because `ship_address` is an alias for `default_address` in the `UserAddressBook` module. https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/user_address_book.rb#L53 However bill_address is not an alias, so it is not prefilled and user has to enter it every time. Rather than making it into an alias, just try default_address in `assign_default_address` if user has one.
peterberkenbosch
force-pushed
the
942-billing-to-default-address
branch
from
8fcc940 to
fd1bf51
Compare
|
@tvdeyen Fixed the conflict, when CI is green this is mergeable. |
|
And it's not :), failing on the introduced spec even. Will investigate and fix. |
peterberkenbosch
force-pushed
the
942-billing-to-default-address
branch
from
fd1bf51 to
c650a18
Compare
| @@ -191,7 +191,7 @@ def find_transition(options = {}) | |||
| transition[options[:from].to_sym] == options[:to].to_sym | |||
| end | |||
| end | |||
|
|
|||
update for solidusio#942 including specs changes. The PR stalled, cherry-picked the commit and updated the spec suite to reflect the changes. Closes solidusio#942
peterberkenbosch
force-pushed
the
942-billing-to-default-address
branch
from
c650a18 to
abaa73f
Compare
|
So, in #1954 we deprecated |
|
@tvdeyen we are all green here! |
update for #942 including specs changes.
The PR stalled, cherry-picked the commit and updated the spec suite to
reflect the changes.
Closes #942