Set billing address to default address #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,11 +295,14 @@ def ship_address_attributes=(attributes) | |||
|
|
|||
| def assign_default_addresses! | |||
| if user | |||
| bill_address = (user.bill_address || user.default_address) | |||
| ship_address = (user.ship_address || user.default_address) | |||
|
|
|||
yeonhoyoon
changed the title
|
Great catch...I was going to figure out a good way to do this myself, except less good. When I am beaten to the punch, it is usually because of another Asian guy in glasses. |
jgujgu
added a commit
to jgujgu/callisto
that referenced
this pull request
Mar 8, 2016
One open PR removes the problem I was having with the default billing address not being prefilled. solidusio/solidus#942 I will remove this file once the PR is merged.
|
😎 |
|
This is 👍 by me. However, would you care to merge the second (fixup) commit into the first one? |
Set `bill_address` to default address, if user has one. Currently when order goes to `address` state, only ship address gets filled in from a previously entered address. This is because `ship_address` is set to default address because `ship_address` is an alias for `default_address` in the `UserAddressBook` module. https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/user_address_book.rb#L53 However bill_address is not an alias, so it is not prefilled and user has to enter it every time. Rather than making it into an alias, just try default_address in `assign_default_address` if user has one.
|
@mamhoff sure, squashed them. |
|
👍 |
|
Thanks! I would love to see tests for this |
|
@yeonhoyoon This is good to go, except it needs some specs. |
|
Closing as stale. Please reopen if you think this is still something we should to tackle. |
peterberkenbosch
pushed a commit
to peterberkenbosch/solidus
that referenced
this pull request
Jun 20, 2017
update for solidusio#942 including specs changes. The PR stalled, cherry-picked the commit and updated the spec suite to reflect the changes. Closes solidusio#942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
bill_addressto default address, if user has one.Currently when an order goes to
addressstate, onlyship_addressgets filled in from a previously entered address. This is becauseship_addressis an alias fordefault_addressin theUserAddressBookmodule.https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/user_address_book.rb#L53
However,
bill_addressis not an alias, so it is not prefilled and user has to enter it every time. Rather than making it into an alias, just try default_address inassign_default_address!if user has one.