Ensure helper is specified in VariantsController #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [backend/app/views/spree/admin/variants/_form.html.erb](https://github.com/solidusio/solidus/blob/master/backend/app/views/spree/admin/variants/_form.html.erb#L73) now uses a helper method called `show_rebuild_vat_checkbox?` which is defined in [Spree::Admin::ProductsHelper](https://github.com/solidusio/solidus/blob/master/backend/app/helpers/spree/admin/products_helper.rb#L28). This helper is not automatically included if `config.action_controller.include_all_helpers` is configured to false. See [PR solidusio#1496](solidusio#1496) for rational and previous discussion on this topic.
mamhoff
approved these changes
Feb 24, 2017
eric1234
added a commit
to eric1234/solidus
that referenced
this pull request
Mar 14, 2017
Another fix to make Solidus `config.action_controller.include_all_helpers = false` compatible. See PR solidusio#1496 and PR solidusio#1714 for background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend/app/views/spree/admin/variants/_form.html.erb now uses a helper method called
show_rebuild_vat_checkbox?which is defined in Spree::Admin::ProductsHelper.This helper is not automatically included if
config.action_controller.include_all_helpersis configured to false. See PR #1496 for rational and previous discussion on this topic.