Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify helper used in CustomerReturnsController #1771

Merged
merged 3 commits into from
Mar 16, 2017

Conversation

eric1234
Copy link
Contributor

Another fix to make Solidus config.action_controller.include_all_helpers = false compatible.

See PR #1496 and PR #1714 for background.

Another fix to make Solidus `config.action_controller.include_all_helpers = false` compatible.

See PR solidusio#1496 and PR solidusio#1714 for background.
@eric1234
Copy link
Contributor Author

Found a few more while working so just added them to the same branch. Let me know if you guys prefer me to squash the commits.

Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with or without the squash, great improvement though, thanks 👍

@jhawthorn jhawthorn merged commit b5af644 into solidusio:master Mar 16, 2017
@jhawthorn
Copy link
Contributor

👍 Thank you

@eric1234 eric1234 deleted the patch-2 branch March 16, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants