Use an icon as missing image placeholder #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This displays a nicer placeholder for representing a missing image on products or variants. It uses a font icon instead of linking to a PNG asset. This has the advantage of being i18n friendly (the previous PNG was english), and is slightly more convenient to use technically (doesn't require sprockets resolving the image path). It also looks nicer.
jhawthorn
force-pushed
the
image-placeholder
branch
from
122dcb3 to
79bb558
Compare
tvdeyen
reviewed
Mar 8, 2017
| <img src="{{ image.mini_url }}"> | ||
| {{else}} | ||
| <span class="image-placeholder mini"></span> | ||
| {{/if}} |
There was a problem hiding this comment.
Could this be a handlebars partial?
There was a problem hiding this comment.
Not sure about that because we need to do the lookup of mini_url/small_url, but maybe a helper. I'll investigate.
There was a problem hiding this comment.
It can be done! I think it warrants further discussion. I will open a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays a nicer placeholder for representing a missing image on products or variants. It uses a font icon instead of linking to a PNG asset.
This has the advantage of being i18n friendly (the previous PNG was english), and is slightly more convenient to use technically (doesn't require sprockets resolving the image path). It also looks nicer.
Before:
After:
