Add image partial to handlebars #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous change to the image placeholder this was displaying incorrectly (the size was being calculated slightly differently). There was no reason to float this outer div which had two inner floating divs.
When I first wrote this I didn't know how to index an array in handlebars. Now I do! This is better to have in handlebars because it's simpler and the JS doesn't need to care that an image is being displayed.
jhawthorn
force-pushed
the
handlebars_image_partial
branch
from
de595bc to
10508c1
Compare
|
Who ever finds the verb can keep it 😅 |
gmacdougall
approved these changes
Mar 13, 2017
cbrunsdon
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Handlebars partial for rendering images or their placeholder. As suggested by @tvdeyen in #1760
To be able to index the correctly sized image url, I needed to use the handlebars
lookuphelper, which allows looking up by a dynamic attribute, as well as introduce a newconcathelper to get the correctly named key (ex.mini_urlfrom"mini"). A little hacky, but it works well and isn't noticeable to anyone calling the partial.At the same time I've moved the code to dig the image data out of the variant JSON into handlebars, which is a bit simpler and nicer.