Remove StockMovements#new #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
remove_stock_movements_new
branch
from
9e26273 to
0cc5459
Compare
I broke this page over a year ago in 0f5c0d0 Nobody noticed so it should probably be safe to remove. This page previously provided an interface to manually create a stock movement. I think this can more easily be done by editing stock from our stock management page.
jhawthorn
force-pushed
the
remove_stock_movements_new
branch
from
0cc5459 to
2e6aef0
Compare
cbrunsdon
approved these changes
Mar 15, 2017
|
I don't think this will be missed. It was introduced ages before we had our current stock editing interface, which can do the same task this does, but with much clearer UI. If I'm mistaken, please reach out via GH issue or Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke this page over a year ago (sorry). There is a javascript error when trying to use the stock item select. Nobody noticed so it should probably be safe to remove.
This page previously provided an interface to manually create a stock movement. I think this can more easily be done by editing stock from our stock management page.